Skip to content

fallback for truncated ListObjects V1 responses without NextMarker#1584

Merged
lesserwhirls merged 1 commit into
Unidata:maint-5.xfrom
387809109:swift-s3-pagination
Jul 20, 2026
Merged

fallback for truncated ListObjects V1 responses without NextMarker#1584
lesserwhirls merged 1 commit into
Unidata:maint-5.xfrom
387809109:swift-s3-pagination

Conversation

@387809109

@387809109 387809109 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

For non-AWS endpoints, netCDF-Java 5.9.1 selected ListObjects V1.

The original pagination logic was:

String continuationToken =
    useV2
        ? responseV2.nextContinuationToken()
        : responseV1.nextMarker();
updateObjectList(continuationToken);

A direct AWS SDK ListObjects V1 request for Swift returned:

count=1000
isTruncated=true
nextMarker=null

The page was valid and truncated, but Swift did not return NextMarker, therefore netCDF-Java repeatedly requested the first page.

changed that part to add a fallback for truncated ListObjects V1 responses without NextMarker

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@CLAassistant

CLAassistant commented Jul 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lesserwhirls lesserwhirls added this to the 5.11.0 milestone Jul 17, 2026
@lesserwhirls lesserwhirls added the bug Something isn't working label Jul 17, 2026
@lesserwhirls

Copy link
Copy Markdown
Member

Thank you for your contribution! This looks ready to go from my end. Once you mark it as ready for review I will happily merge this fix.

@387809109
387809109 marked this pull request as ready for review July 17, 2026 23:38
@387809109
387809109 requested a review from lesserwhirls as a code owner July 17, 2026 23:38
@lesserwhirls
lesserwhirls merged commit c7381fb into Unidata:maint-5.x Jul 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants