Conversation
jthorborg
left a comment
There was a problem hiding this comment.
Audio LGTM regardless, but could be more aggressively trimmed.
Having authored some of these original skills and seeing the description evolved, I'm curious as to why we made those changes in the first place, or if we can somehow measure agent performance impact of doing this.
I'm going to try and trim all of them a bit more aggressively, since we're still far from where want to be.
These changes are being done primarily to satisfy a requirement from Codex. Codex will drop skills at a point when character limits exceed a threshhold. Apart from that, we're broadly trying to work towards aligning skill descriptions to our rules here: https://internal.docs.unity.com/en-us/docs-quality/documentation/skill-model. This guidance was written mostly as a synthesis over Anthropic's guidance, so the field is a bit muddied now with these requirements from Codex. |
5c2ebff
|
Apologies to my reviewers. I made even more judicious reductions to try and fit Codex requirements. |
Conflicts were description-only in four skills. main's side is the folded copy of the pre-shortening text (from #74, the squash of this branch's own YAML-quoting fix), so this branch's shortened descriptions win in all four. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
karljj1
left a comment
There was a problem hiding this comment.
Approving skills/localization/SKILL.md
Antoine-Lassauzay
left a comment
There was a problem hiding this comment.
Approved on behalf of the UI team, but I agree there is a subtle change of meaning to the UI routing skill that may lead agents to bypass it.
b864c2c
@Antoine-Lassauzay I changed the description for the routing table in response to yours and @ziyiunity's feedback. |
For this PR, I tried to shorten the skill descriptions to make the plugin more performant for Codex.
This branch was created from the branch used to create this PR: #74.
Here is a table comparing the character limit changes. "Before" is what's on
mainnow and "After" is the current branch.