fix(localization): enforce the batch-localize confirmation in code - #82
Merged
Merged
Conversation
chris-addison
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
L10nBatchProcessor.LocalizeAllopens, modifies and saves every scene underAssets/. The only safeguard was a sentence in SKILL.md asking the agent to confirm with the user first, so an agent that skipped it, or a developer who called the template directly, would rewrite every scene and discard unsaved work in the open scene with no prompt.Change
The safeguards now live in
LocalizeAllitself:EditorUtility.DisplayDialogreturnstruewithout showing anything.EditorSceneManager.SaveCurrentModifiedScenesIfUserWantsTo()first, so unsaved changes are saved or explicitly discarded; Cancel aborts.OperationCanceledException.SKILL.md keeps the existing "ask before acting" step and now tells the agent the method enforces this itself, that the user confirms in the Editor, and that a cancellation must not be worked around.
Verification
The new
LocalizeAllcompiles against the Unity 6000.6 Editor assemblies, with the unchanged Localization/TMP-dependent helper stubbed. Not yet exercised end to end in a live Editor with the Localization package; worth a quick run by the skill owner before merge.