Repository navigation
Conversation
Classify Freighter rejections and Soroban RPC/network failures into user-facing messages, and stop reporting them as wrong answers: submit errors now surface through the error alert instead of an "Incorrect" feedback toast, and the submit/hint spinners always clear. Add end-to-end component tests that drive the real hook and component through rejected signatures, failed account lookups, rejected transactions, hint failures, and rejected connection prompts, asserting the error text and that the controls return to an interactive state. Closes UnityChainxx#762 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@nasalehj Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #762. Adds explicit coverage for user-rejected transactions and RPC failures, and fixes the UI so those failures are not rendered as wrong answers.
Behaviour fix
frontend/lib/wallet-errors.jsclassifies Freighter rejections (code 4001or reject/cancel messages) and transport/RPC failures (fetch/network/timeout/5xx, including a transaction that never finalises) into user-facing messages. The existing "unsupported network" guidance is preserved.usePuzzleContractnow routes submit and hint failures through the error state instead of the answer feedback state, so a rejected signature shows an error alert rather than an "Incorrect" toast. Both spinners still clear infinally.Tests (
frontend/tests/wallet-error-paths.e2e.test.jsx, part ofnpm test)The component tests drive the real hook and component end to end with a hermetic Freighter/RPC double.
Verification
Full frontend suite: 23 failing tests before and after this change (pre-existing environment issues in other spec files), with the 5 new tests added to the passing set — no regressions.
Closes #762