Skip to content

Fix ticket search endpoint for text and status filters #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unlock7 merged 1 commit into from
Jun 17, 2026
Merged

Fix ticket search endpoint for text and status filters #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/net/hackyourfuture/tickettrackingsystem/controller/TicketController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import net.hackyourfuture.tickettrackingsystem.dto.ticket.TicketRequest;
import net.hackyourfuture.tickettrackingsystem.dto.ticket.TicketResponse;
import net.hackyourfuture.tickettrackingsystem.model.Ticket;
import net.hackyourfuture.tickettrackingsystem.service.TicketService;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.*;
Expand All @@ -26,6 +27,14 @@ public ResponseEntity<List<TicketResponse>> getAll() {
return ResponseEntity.ok(service.getAll());
}

@GetMapping("/search")
public ResponseEntity<List<Ticket>> search(
@RequestParam(required = false) String status,
@RequestParam(required = false) String text
) {
return ResponseEntity.ok(service.search(status, text));
}

@GetMapping("/{id}")
public ResponseEntity<TicketResponse> getById(@PathVariable Long id) {
return ResponseEntity.ok(service.getById(id));
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/hackyourfuture/tickettrackingsystem/repository/TicketRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public List<Ticket> findAll() {
// -----------------------------
// SEARCH (text + status)
// -----------------------------
public List<Ticket> search(String text, String status) {
public List<Ticket> search(String status, String text) {
StringBuilder sql = new StringBuilder("SELECT * FROM tickets WHERE 1=1 ");
List<Object> params = new java.util.ArrayList<>();

Expand Down
4 changes: 3 additions & 1 deletion src/main/java/net/hackyourfuture/tickettrackingsystem/service/TicketService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ public TicketService(
this.users = users;
this.email = email;
}

public List<Ticket> search(String status, String text) {
return tickets.search(status, text);
}
public TicketResponse create(TicketRequest req) {
Ticket t = new Ticket(
null,
Expand Down
Loading