Skip to content

upipe_transfer: do not leak a reference when freeze fails #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JDarnley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upipe_transfer: do not leak a reference when freeze fails #1228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/upipe-modules/upipe_transfer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,9 @@ static int _upipe_xfer_mgr_attach(struct upipe_mgr *mgr,
static inline int _upipe_xfer_mgr_freeze(struct upipe_mgr *mgr)
{
struct upipe_xfer_mgr *xfer_mgr = upipe_xfer_mgr_from_upipe_mgr(mgr);
UBASE_RETURN(umutex_lock(xfer_mgr->mutex));
upipe_mgr_use(mgr);
return umutex_lock(xfer_mgr->mutex);
return UBASE_ERR_NONE;
}

/** @This thaws the remote event loop previously frozen by @ref
Expand Down
Loading