Fix random GitHub avatar on locally imported plugin rows - #128
Merged
dragonx943 merged 1 commit intoSep 27, 2026
Merged
Conversation
Plugin rows without a repository only set a static drawable, leaving the Coil request from the recycled view holder alive. Its result lands after the bind and overwrites the icon, so a local plugin shows whichever GitHub avatar was loaded before, changing on every refresh. Dispose the pending request before setting a static icon, and dispose superseded requests when a new one is enqueued.
dragonx943
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A locally imported plugin (no GitHub repository in its metadata) shows a random GitHub avatar in Manage plugins, and the avatar changes on every refresh.
Cause
PluginManageAdapteronly sets a static drawable (ic_services/ fallback favicon) for rows without a repository, but never cancels the Coil request left over from the previous holder of that recycled view. The request completes after the bind and overwrites the icon with whatever avatar was loaded before, so the row shows a stale GitHub avatar — whichever one the holder happened to render last.Fix
PluginManageAdapter(same pattern asScrobblerConfigActivity).CoilImageView.enqueueRequest, so an in-flight request from a recycled view can no longer land on the row that replaced it.Testing
Code review only so far — the device build was skipped to avoid an OOM while compiling. Please verify locally: import a
.jar, open Manage plugins, refresh a few times; the row keeps the static puzzle icon.