Fix Google Photos uploads and MCP HEAD responses#1428
Open
saga-agent wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/uploadsinstead of the invalid/uploadspathHEADon bare, org-scoped, and toolkit MCP routes with405 application/jsonbefore the SPA fallback can turn it into200 application/octet-stream@executor-js/plugin-openapiRoot cause
HttpServerResponse.raw(response)preserved the nested webResponsefor ordinary requests, but Effect strips the body forHEADand serializes the outer wrapper. Because the outer wrapper did not copy the nested status and headers, the result became an empty200without an MCP content type; nginx surfaced that asapplication/octet-stream.Verification
bun run --cwd packages/plugins/openapi test -- src/providers/google/discovery.test.ts(10 passed)bun run --cwd packages/hosts/mcp test(65 passed)bun run --cwd apps/host-selfhost test -- src/mcp/org-path.test.ts src/mcp/mcp.test.ts(10 passed)bun run --cwd packages/hosts/mcp typecheckbun run --cwd apps/host-selfhost typecheckoxfmt --checkandgit diff --checkHEAD /mcp,HEAD /default/mcp, andHEAD /mcp/toolkits/deployeach returned405 Method Not AllowedwithContent-Type: application/json;HEAD /remained200 text/htmlThe complete self-host test command was also attempted, but its existing long-lived daemon test did not exit, so it is not represented as a passing check here.