Repository navigation
fix(crate): packing a FARP reports how many crates were created - #268
Merged
Merged
Conversation
Closes #263 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lot
FIX-FARP-PACK-FALSE-SUCCESS, closes #263. The Pack command destroys the FARP first (packScene), then creates the crates, and threw away the count that the creation returns: the pilot always read "FARP packed successfully!", even when DCS refused every object and the FARP was lost with no crate (and the warehouse share of the missing crates with it).The command now reads the count: none → "Pack failed: the crates could not be created." + ERROR log; only some → "FARP packed: N of M crates created." + WARNING log; all → the existing message. Decided with the maintainer: message only — the order (destroy, then create) is unchanged; creating the crates before destroying the scene stays a separate decision. Two new keys, FR/ES/KO written by me (to review), dictionaries regenerated by
merge_CTLD.ps1(translation_version1.26 → 1.27).Test plan
crate_scene_pack_placement_spec(all created = control, none, only some): the two failure cases failed before the change; the 4 existing cases unchangedbustedovertests/ci/*— 0 failures; luacheck onsrc/— 0 warnings🤖 Generated with Claude Code