Repository navigation
fix(i18n): JTAC radio messages go through ctld.tr and the guard recognises the alias - #269
Merged
Merged
Conversation
…nises the alias Closes #265 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ATE-ALIAS entry Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lot
FIX-I18N-TRANSLATE-ALIAS, closes #265.ctld.i18n_translateis an alias ofctld.tr, but the dictionary generator (hence thei18n-guardjob and thepre-pushhook, which run it) only scans for the literalctld.tr(.CTLD_jtac.luacalled the alias 16 times: those 16 keys were in no English dictionary (13 of them in none at all), so every JTAC radio call came out in English on a French, Spanish or Korean server, withlasing/standing by oninserted in the middle of a translated sentence.Decided with the maintainer: replace the alias in
src/, check it has no caller left, and keep it supported for scripts outside the repository.ctld.tr;src/has no caller of the alias left (checked by search ofsrc/,tools/,tests/,docs/);CTLD_i18n.lua(comment updated) and the generator's scan now matches both names, so a key written through the alias still reaches the dictionaries;translation_version1.27 → 1.28) and translated FR / ES / KO — my translations, to review; the radio sentences insert a verb (lasing/standing by on) and a target type, so the word order of a few of them differs from the English one;ctld.tror to the alias insrc/is a key of the English dictionary (it failed on the 16 JTAC keys before the change);Test plan
i18n_source_keys_spec: failed on the 16 JTAC keys before the change, passes afterbustedovertests/ci/*— 0 failures; luacheck onsrc/— 0 warningsmerge_CTLD.ps1; the translations survive a rebuild🤖 Generated with Claude Code