Repository navigation
fix(config): a list newer than the mission configuration takes its default (FIX-CONFIG-NEW-LISTS) - #275
Merged
Conversation
…fault (FIX-CONFIG-NEW-LISTS) A configuration omits a list to remove it (ADR 0011), but one written before catalogue 2.3.0 never had the Fat Cow lists: CTLD read them as removed and the Fat Cow had no aircraft, crate or loadout (VEAF Open Trainings, configs at 2.2.0). The build dates every list from the pinned shapes (ctld-tools since -> ctld.configListSince); the engine and ctld-tools complete() give a list newer than the configuration's version its default. ADR 0011 Addendum 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
davidp57
added a commit
to VEAF/VEAF-Mission-Creation-Tools
that referenced
this pull request
Oct 27, 2026
… the mission is missing, not removed (#1204) * chore(vendored): take CTLD 2.0.0-rc15, the Fat Cow; a list newer than the mission is missing, not removed rc15 ships the Fat Cow (VEAF/CTLD#273) and catalogue 2.3.0, and gives a list newer than a mission's configuration its default (VEAF/CTLD#275): in rc14 a 2.2.0 ctld-config.yaml had no Fat Cow aircraft, crate or loadout. validate and ctld-upgrade read ctld.configListSince from the vendored engine, so ctld-upgrade writes the Fat Cow lists in instead of stamping 2.3.0 over their absence. Release asset, LF-normalised. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(backlog): CHORE-VENDOR-CTLD-RC15 is PR #1204 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(types): read_list_since takes the optional engine path Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mission configuration omits a list to remove it (ADR 0011), but a configuration written before catalogue
2.3.0never had the Fat Cow lists. CTLD readfatCowTypes,fatCowCrates,fatCowLoadoutsandfatCowAICowsas removed: the Fat Cow was on with no aircraft, no crate and no loadout. Found on the VEAF Open Trainings, whosectld-config.yamldate from2.2.0.Change (ADR 0011 Addendum 3)
ctld-tools sincedates every list from the pinned shapes (tests/ci/data/catalogue_shapes) and writesctld.configListSincenext toctld.configDefault(generated, git-ignored, merged intoCTLD.lua).CTLDConfig:load()gives a list newer than the snapshot'sconfigVersionits default (localised) and names it in the startup notice. A list omitted at or after its own version, or not dated, stays a removal.complete()adds such a list when a configuration is opened, reading the table from the engine it installs, so saving no longer stamps the omission as a removal.Tests
config_param_tier_spec.lua(2.2.0 / no version / 2.3.0 / kept list / undated list).test_list_since.py(generator, CLI, engine reader, completion).Docs: mission-maker configuration EN + FR, ADR 0011 Addendum 3, CHANGELOG.
🤖 Generated with Claude Code