Prefix HSSS result IDs with Variant_ instead of NGS_SNP. - #310
Merged
Conversation
Paired with the separator fix in ApiCommonWebService, this makes the HSSS plugins emit VariationRecordClass source_ids. This is an ApiCommon cohort default and so applies to every project in the cohort, which is safe because no project has a live snp or chip search -- those imports are commented out in the shared apiCommonModel.xml. The chip default (highspeedchipsnpsearchconfig_idPrefix: 'NULL') is left alone; the chip path is equally dead but out of scope. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Both values change for every gene, so saved strategies filtering on either will return different results. Also notes the three columns relabelled to match what they actually contain. The date attribute is left as a placeholder - it must be set to the release date before this ships. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This reverts commit a039aee.
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the HSSS plugins emit
VariationRecordClasssource_ids, by changing the ApiCommoncohort default for the result-ID prefix:
Paired with the separator fix in
ApiCommonWebService#20, this produces IDs of the formVariant_<sequence>_<location>— which is what the record class has always actually held,and what
ApiCommonModel#212 renames the record to match.Merge with
ApiCommonModel#212 andApiCommonWebService#20. The prefix, theseparator, and the record-class naming are one change spread across three repos; any two
of the three without the third leaves the HSSS searches emitting IDs the record class
won't resolve.
Scope of the cohort default
This is an ApiCommon cohort default, so it applies to every project in the cohort, not
just PlasmoDB. That is safe because no project has a live
snporchipsearch — thoseimports are commented out in the shared
apiCommonModel.xml. The chip default(
highspeedchipsnpsearchconfig_idPrefix: 'NULL') is left alone: that path is equally deadbut out of scope here.
The release note was pulled from this PR
This PR previously carried a
news.xmlentry for the corrected density and dN/dSstatistics. It has been reverted (
965009fddrevertsa039aeee9) because itsdateattribute was an unresolvable placeholder — the news page would have rendered
TBD - set to the release dateliterally, and inventing a date was not an option.The drafted text is preserved in this branch's history and can be recovered with
git show a039aeee9when the release date is known. It should return as its own PR atthat point. Nothing about the statistics themselves changed; only the announcement is
deferred.
Related PRs
The variants work spans four repos. These four merge together —
ApiCommonModel's record rename is a contract the other three depend on by name:ApiCommonModelRename the Variation record to Variant; add a precomputed SNV characteristics search ApiCommonModel#212 — record rename + precomputed SNV characteristics searchApiCommonWebServiceFix SNV density and dN/dS in the sample-set SNV search, and revive its test suite ApiCommonWebService#20 — density and dN/dS fixes, test-suite repairApiCommonWebsitePrefix HSSS result IDs with Variant_ instead of NGS_SNP. #310 — HSSS result-ID prefix (NGS_SNP.→Variant_)web-monorepoShow the Variant record id without the record-type prefix web-monorepo#1841 — record-heading override, filename tracking the renameCoupling worth knowing when sequencing the merges: #1841's customization is resolved by
recordClass.fullName, so without #212 it matches nothing and the override silently stops applying — no error, just the default heading back. #310's prefix and #20's separator together produce the ids #212's record class resolves; any two without the third leaves HSSS emitting ids the record class rejects.Related but independent, cherry-picked onto
master— merge before the four above:EbrcModelCommonOptional dataset gate for presenter template injection (partial-appDb builds) EbrcModelCommon#131 — optional dataset gate for presenter template injection. Not part of the variants work; needed to build a site against a partial appDb.The release note originally in #310 has been deferred (reverted in
965009fdd) because itsdateattribute was an unresolvable placeholder. Recover the drafted text withgit show a039aeee9in ApiCommonWebsite and re-PR it once the release date is known.