Skip to content

Matrix lint workflow by hook stage #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Feb 15, 2026
Merged

Matrix lint workflow by hook stage #2842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
matrix:
python-version: ['3.13']
platform: [ubuntu-latest, windows-latest]
hook-stage: [pre-commit, pre-push, manual]

@cursor cursor Bot Feb 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lite-action in matrix jobs pushes incomplete auto-fixes

Medium Severity

Adding hook-stage to the matrix means pre-commit-ci/lite-action now runs in 6 parallel jobs, each containing auto-fixes from only a single hook stage. Previously, each job ran all three stages sequentially, so the action had the complete set of fixes. The pre-commit-ci/lite-action documentation requires it to be in a job that is "either by itself in the workflow or is the last job to finish," which 6 parallel matrix jobs violate. Only the last job's partial fixes will be pushed, losing fixes from the other two stages.

Additional Locations (1)

Fix in Cursor Fix in Web


runs-on: ${{ matrix.platform }}

Expand All @@ -37,10 +38,8 @@ jobs:
# Use bash to ensure the step fails if any command fails.
# PowerShell does not fail on intermediate command failures by default.
shell: bash
run: |
uv run --extra=dev prek run --all-files --hook-stage pre-commit --verbose
uv run --extra=dev prek run --all-files --hook-stage pre-push --verbose
uv run --extra=dev prek run --all-files --hook-stage manual --verbose
run: uv run --extra=dev prek run --all-files --hook-stage ${{ matrix.hook-stage }}
--verbose
env:
UV_PYTHON: ${{ matrix.python-version }}

Expand Down