Repository navigation
docs: Document experimental Payjoin wallet RPC workflow - #15
Merged
ValeraFinebits merged 6 commits intoOct 22, 2026
Merged
ValeraFinebits merged 6 commits into
ValeraFinebits merged 6 commits into
Conversation
ValeraFinebits
force-pushed
the
feat/async-payjoin
branch
from
October 21, 2026 19:13
210884a to
1705174
Compare
ValeraFinebits
force-pushed
the
docs/Document-experimental-Payjoin-wallet-RPC-workflow
branch
from
October 21, 2026 19:28
32cc3c3 to
25a98e1
Compare
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking documentation discrepancies or regressions in the narrowly scoped supporting changes.
No open issues 🎉
What changed in this PR
Documents the experimental Payjoin wallet RPC workflow, its safety limitations, and how to build and test the integration.
Changes:
- Adds an RPC guide covering payment submission, monitoring, retries, networking, and wallet lifetime.
- Expands build and test instructions, records follow-up work, and clarifies API contracts and RPC help.
- Adjusts record serialization, test logging setup, and integration CI configuration arguments.
| File | Description |
|---|---|
src/wallet/test/payjoin_sender_tests.cpp |
Sets the lock-debug level while preserving other category levels. |
src/wallet/rpc/payjoin.cpp |
Clarifies RPC states, error codes, and retry behavior. |
src/wallet/payjoin/sender.h |
Documents sender state, operations, and lifecycle contracts. |
src/wallet/payjoin/sender.cpp |
Replaces the record serialization macro with an explicit serializer. |
src/wallet/payjoin/manager.h |
Documents manager ownership and shutdown requirements. |
src/payjoin/transport.h |
Clarifies delivery, callback, cancellation, and shutdown contracts. |
src/payjoin/http_transport.h |
Documents HTTP options and transport guarantees. |
src/payjoin/client.h |
Clarifies URI parsing and session operation contracts. |
src/payjoin/client.cpp |
Updates comments describing wallet-side validation. |
README.md |
Highlights experimental Payjoin support and links its guides. |
doc/README.md |
Adds Payjoin documentation to the index. |
doc/payjoin-todo.md |
Records remaining integration work and completion criteria. |
doc/payjoin-rpc.md |
Introduces the wallet RPC workflow and safety guide. |
doc/payjoin-integration.md |
Expands build, test, smoke-test, and CI instructions. |
ci/test/03_test_script.sh |
Passes shared configuration arrays to the integration build. |
Review effort: Balanced
ValeraFinebits
marked this pull request as ready for review
October 22, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.