Repository navigation
build: Pin Payjoin release version in source - #18
Merged
ValeraFinebits merged 2 commits intoOct 23, 2026
Merged
ValeraFinebits merged 2 commits into
ValeraFinebits merged 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Static inspection supports consistent version and build-suffix handling, with no blocking issues identified; the release workflow was not executed.
No open issues 🎉
What changed in this PR
This PR pins the Payjoin release version in source and uses it consistently in build metadata and release archives, while preserving Bitcoin Core’s RPC and peer version identifiers.
Changes:
- Adds a shared Payjoin version definition and passes it to the client-version build target.
- Includes the Payjoin release version in full version strings.
- Derives archive names from source and verifies packaged binary versions and isolated regtest RPC output.
| File | Description |
|---|---|
src/payjoin/version.cmake |
Defines the pinned Payjoin release version. |
src/payjoin/CMakeLists.txt |
Supplies the version to bitcoin_clientversion. |
src/clientversion.cpp |
Adds Payjoin metadata while retaining build suffix handling. |
.github/workflows/payjoin-release.yml |
Reads source versions and checks archive, binary, and RPC consistency. |
Review effort: Balanced
ValeraFinebits
marked this pull request as ready for review
October 23, 2026 08:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.