Repository navigation
Conversation
Collaborator
|
I reviewed PR #11 at head 7d69eba, against base 46197a4. Static checks, both Compose configurations, and all 17 task-local tests passed. However, two reproducible grading issues should be fixed before merging:
The instruction and model-observation runtime hashes match the reviewed revision. The reported near-threshold model failure is consistent with the exact quality gate; it does not justify lowering the threshold. Please revalidate the affected layers after the fixes and make the available model source, command logs, and trajectory evidence accessible for maintainer review outside the public task package. Official asset publication, redistribution-rights review, and a passing merge-ready check remain separate merge prerequisites. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
tasks/rust-bm25-search, a CPU task requiring a complete Rust BM25 engineand persistent inverted index built from all 8,841,823 MS MARCO Passage v1 texts.
The separate verifier recompiles submitted source, rebuilds the index, and
scores all 6,980 standard dev queries. MRR@10 must reach the measured Pyserini
1.4.0 reference at k1=0.9, b=0.4: exactly 3236243/17589600 (0.18398616227770956).
Above this floor, equal geometric weights reward quality, warm search time and
index size relative to a freshly measured reference in the same verifier.
The task reports five fresh-process startup samples, warm latency, sequential
throughput, index bytes, build time and sampled process RSS. Cold means a new
process without query warmup; OS file cache is not evicted. Both phases use
four CPUs, 16 GiB memory, Rust 1.85.1 and locked offline generic dependencies.
The submission must implement its own indexing and BM25 retrieval; existing
search engines and prebuilt indexes are excluded. Submitted search runs without
grading privileges and can read only its immutable index, binary and libraries.
Author: MXueguang x93ma@edu.uwaterloo.ca.
Reviewed structural precedent:
tasks/sparse-retrieval-pruningat base46197a43f8cbb364e72b6d63d5db873ae7d2cac8. Reused patterns are CPU execution,source artifact transfer, separate verifier, clean rebuild, unprivileged
candidate execution and a baseline-relative objective behind a quality gate.
Differences are raw-text indexing entirely in Rust, standard MS MARCO passage
dev MRR, a measured Pyserini reference, and explicit startup/disk measurements.
The structured contract and natural-language instruction were checked for
semantic equivalence; the mapping is in
authoring/instruction-equivalence.md.Validation evidence
Evaluated task runtime:
ae5a6f6c10283559953dfe90270b5ff659b88477.Evidence commit:
7d69eba145965e6c9136498bffbb596d5588dbc3(authoring documentation only).python scripts/check_tasks.py tasks/rust-bm25-searchandpython scripts/check_release.py: review-stage checks pass.because the optional host dependency is absent. Task-local tests: 17 passed.
pass. Missing source, malformed Cargo manifests, command failure and malformed
search output return zero in independent verifier runs.
trial pass with MRR@10 0.18729482194023742 and byte-identical outputs for
all 6,980 queries. The Harbor job has one completed trial, zero errors and
reward 0.379283503451. Its three source artifacts transfer byte-for-byte.
for the warm dev batch (62.831 queries/s), with 0.439 s process-cold
median. The freshly rebuilt Pyserini reference reproduces its exact MRR.
The score below 0.5 reflects the simple author's slower warm search despite
passing the quality floor; it is not a model-agent score.
(
fork_turns="none") completed the task in a clean offline 4-CPU/16-GiBcontainer. The separate verifier completed without errors, but MRR@10
0.1839805908036567 is lower than the exact floor by 7/1256400, so
reward is 0. Source review confirmed self-built Rust indexing/search.
(405.437 queries/s) and has 45.732 ms process-cold median and
634,356 KiB sampled peak search RSS. Its same-run reference reproduced
the pinned MRR, with 26.096 s, 267.474 queries/s and 659,074,562 bytes.
Reciprocal rank differs on only four queries: one better, three worse. This
is a valid near-threshold failure; the quality gate was preserved and no
second model attempt was launched to seek a pass. See the model observation.
9f566cfdd7465d093da2c619a0d2ad6936ad39dcdbad0a630193b52328de8b62.Executed and final source/image fingerprints, metrics and limitations are in
validation record and
Harbor observation. A Cargo
manifest rejection guard added after the full run passed its unit regression
and fresh-container test; the later author edit changes metadata only.
Validation scope: Author runs, Harbor Oracle integration and one independent
hosted-model trial are complete. The new model trial used Codex collaboration
and the unmodified separate verifier; it did not run Harbor's pinned Codex CLI.
A direct OpenAI API preflight for the requested model returned exhausted
credits before a Harbor coding-agent trial started. Full hosted-model trajectory
and token/billing data were not exported; source, agent notes, container command
events and grading logs are retained locally. Grading is deterministic and
needs no model judge. No instruction, threshold, scoring or runtime change
was made after observing the valid zero score.
Merge follow-up:
assets.jsoncurrently uses real immutable Tevatronpins with verified sizes/hashes. The merge-ready check is expected to fail until
maintainers review MS MARCO/TREC redistribution terms, publish approved inputs
under
search-swe/Search-SWE/tasks/rust-bm25-search/, and pin the merged officialHF commit. The upstream sources and terms are recorded in
authoring/SOURCES.md.No dataset or image upload is included in this PR.
Contributor checklist
Maintainer merge checklist