Repository navigation
fix(dashboard): prevent hanging note close animation jump - #43
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing an expanded sticky note briefly moved it hundreds of pixels to the right before returning to its thumbnail. The closing scale also magnified the paper's positioning transform. Compensate that displacement using the actual transform origin so closing starts at the editor's current position; preserve the existing duration, easing, wind motion, and cancellation behavior.
Add a production-build Chromium regression to the existing smoke suite. It samples the first frame and full closing path for hanging and side-pinned notes at default and 110% zoom. Both new tests fail against the old build and pass against the fixed build.
Validation: full
npm run verifypasses; 22 focused tests pass (1 existing skip); all 3 production-build smoke tests pass. Prior browser validation covered rapid reopening, reduced motion, continuous wind motion, and 19 existing note interactions. Only the controller and smoke-test file changed.