Repository navigation
build(deps): use CubeConverter 1.3.1 ViaVersion module - #492
Merged
RaphiMC merged 1 commit intoNov 11, 2026
Conversation
Replace the vv-json branch commit dependency with the named ViaVersion Gson module from CubeConverter 1.3.1. Both Gson variants now build from master, so ViaBedrock no longer relies on a separate converter branch. Include the merged optional null-parent fix. Player geometry that encodes an unparented root as parent:null now retains its model and child hierarchy instead of failing in JsonNull.getAsString(). Keep transitive dependencies disabled to retain the host ViaVersion dependency choices. The named vv-json module preserves the com.viaversion.viaversion.libs.gson API and avoids the repository aggregate that can include both conflicting CubeConverter variants. https://github.com/oryxel1/CubeConverter/tree/1.3.1
Exterminate5573
previously approved these changes
Nov 11, 2026
AlexProgrammerDE
force-pushed
the
stackanvil/0114-use-tagged-cubeconverter-viaversion-module
branch
from
November 11, 2026 13:30
85dd02d to
711036e
Compare
AlexProgrammerDE
changed the title
AlexProgrammerDE
added a commit
to StackAnvil/patches
that referenced
this pull request
Nov 11, 2026
Save the standalone dependency update to com.github.oryxel1.CubeConverter:vv-json:1.3.0 and retain non-transitive resolution. Publish the CubeConverter master tag after verifying both Gson builds, then validate the public JitPack artifact through the upstream ViaBedrock build. Advance ViaBedrock to current main and refresh affected patch context. Route both legacy and named CubeConverter declarations to the local ViaVersion module in StackAnvil setup. Keep that routing and the local regressions outside the upstream PR. Verify full 111-patch replay, standalone build with Checkstyle and tool compilation, 20 focused local resource and skin regressions, and matching local POM coordinates. Upstream PR: ViaVersionAddons/ViaBedrock#492.
AlexProgrammerDE
added a commit
to StackAnvil/patches
that referenced
this pull request
Nov 11, 2026
Advance CubeConverter to the merged null-parent fix and retire its local patch and sidecar. Tag the verified upstream commit as 1.3.1 and update the existing ViaBedrock dependency patch and PR to that public ViaVersion Gson module. Verify 23 tests per Gson backend on the merged source, run null-parent consumers against both published JitPack modules, pass the standalone ViaBedrock build and 20 focused local regressions, and replay the complete local stack. Refresh the existing MoLang patch context for the dependency version change. Upstream PR: ViaVersionAddons/ViaBedrock#492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViaBedrock currently pins a commit from CubeConverter's separate
vv-jsonbranch. Switch to the tagged ViaVersion Gson module built from shared sources onmaster.Use
com.github.oryxel1.CubeConverter:vv-json:1.3.1instead ofcom.github.oryxel1:CubeConverter:8a7b73a8ed.The named module preserves the ViaVersion Gson API and avoids the repository aggregate, which can include both Gson variants.
Keep
transitive = falseso ViaBedrock retains its dependency choices. No Java source changes are required.CubeConverter 1.3.1 includes the merged null-parent fix from CubeConverter PR #8, alongside the geometry and rendering fixes already used by ViaBedrock.
Geometry with
parent: nullnow retains its root and named child hierarchy instead of failing inJsonNull.getAsString().Validation:
mainwithout StackAnvil setup../gradlew clean buildpasses on Java 25, including Checkstyle and tool compilation, against the public tagged JitPack artifact.Created with GPT-6.1 Sol in T3 Code through the Codex harness.