Skip to content

Translate villager data and horse flags - #494

Open
guhlutions wants to merge 1 commit into
ViaVersionAddons:mainfrom
guhlutions:fix/villager-horse-metadata
Open

guhlutions wants to merge 1 commit into
ViaVersionAddons:mainfrom
guhlutions:fix/villager-horse-metadata

Conversation

@guhlutions

@guhlutions guhlutions commented Nov 13, 2026 •

Copy link
Copy Markdown

Problem

Bedrock villagers send their profession in VARIANT, which ViaBedrock currently treats as unsupported. Bedrock horse owner metadata also triggers an entity lookup even though the Java horse has no synchronized owner field. The repeated warnings were observed while playing on a Bedrock 1.26.60 Realm through ViaProxy with Java 26.3.

Changes

  • Combine the profession, biome variant, and trade tier for villager_v2 and zombie_villager_v2 into Java's VillagerData. Reuse stored metadata for partial updates and send one complete value per packet. Bedrock's profession and biome IDs are defined in Mojang's vanilla villager definition.
  • Send the Java horse flags for taming, eating, and rearing from the Bedrock actor flags. Skip the unsupported horse owner field before attempting to look up the owner.

Verification

  • ./gradlew build passed, including Checkstyle.
  • Local packet tests covered all 15 villager professions and 7 biome variants, all trade tiers, partial updates, horse flags, and the existing owner translation for other tameable animals. The translated data was checked on Java 26.3 and through ViaBackwards to Java 1.21.4.
  • The combined ViaProxy test build passed the cat regression check. A live retest on the affected Bedrock 1.26.60 Realm with Java 26.3 reached the PLAY state and loaded the village without the villager variant or horse owner warnings.

Combine Bedrock villager professions, biomes, and trade tiers into Java villager data. Send horse taming and pose flags without resolving owner IDs for entities that lack a Java owner metadata field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant