Repository navigation
Translate villager data and horse flags - #494
Open
guhlutions wants to merge 1 commit into
Open
guhlutions wants to merge 1 commit into
guhlutions wants to merge 1 commit into
Conversation
Combine Bedrock villager professions, biomes, and trade tiers into Java villager data. Send horse taming and pose flags without resolving owner IDs for entities that lack a Java owner metadata field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bedrock villagers send their profession in
VARIANT, which ViaBedrock currently treats as unsupported. Bedrock horse owner metadata also triggers an entity lookup even though the Java horse has no synchronized owner field. The repeated warnings were observed while playing on a Bedrock 1.26.60 Realm through ViaProxy with Java 26.3.Changes
villager_v2andzombie_villager_v2into Java'sVillagerData. Reuse stored metadata for partial updates and send one complete value per packet. Bedrock's profession and biome IDs are defined in Mojang's vanilla villager definition.Verification
./gradlew buildpassed, including Checkstyle.