Repository navigation
push.go: allow configure custom error logger - #134
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 87.96% 87.71% -0.25%
==========================================
Files 12 12
Lines 1437 1441 +4
==========================================
Hits 1264 1264
- Misses 119 121 +2
- Partials 54 56 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Fix all with cubic | Re-trigger cubic
NickPak
pushed a commit
to NickPak/metrics
that referenced
this pull request
Oct 8, 2026
This change lets us pass a custom error logger to the push server, so errors it reports are formatted consistently with other log messages. --- Before: <img width="1512" height="381" alt="Screenshot 2026-09-28 at 16 37 02" src="https://github.com/user-attachments/assets/e75f27ac-e66c-470c-8bd3-042b3144184e" /> After: <img width="1512" height="324" alt="Screenshot 2026-09-28 at 16 06 28" src="https://github.com/user-attachments/assets/8ee04f01-6f17-4e77-aca8-228e124cff39" /> --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change lets us pass a custom error logger to the push server, so errors it reports are formatted consistently with other log messages.
Before:
After: