Skip to content

prometheus_histogram: reject NaN bucket bounds - #135

Open
fallintoplace wants to merge 1 commit into
VictoriaMetrics:masterfrom
fallintoplace:fix/reject-nan-histogram-bounds
Open

fallintoplace wants to merge 1 commit into
VictoriaMetrics:masterfrom
fallintoplace:fix/reject-nan-histogram-bounds

Conversation

@fallintoplace

Copy link
Copy Markdown

What

  • Reject NaN histogram bucket bounds.

Why

  • NaN passes the ordering check and can produce le="NaN" buckets.

Implementation

  • Check every bound with math.IsNaN in ValidateBuckets.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.73%. Comparing base (ad81605) to head (a13e874).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   87.71%   87.73%   +0.01%     
==========================================
  Files          12       12              
  Lines        1441     1443       +2     
==========================================
+ Hits         1264     1266       +2     
  Misses        121      121              
  Partials       56       56              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants