Give the final review five rounds and list what it left open in the PR - #170
Open
adamw wants to merge 1 commit into
Open
Give the final review five rounds and list what it left open in the PR#170adamw wants to merge 1 commit into
adamw wants to merge 1 commit into
Conversation
The whole-run review loop in the built-in flows capped at three fix rounds, and the flows discarded its result, so a PR could open with findings still unfixed and nothing saying so. Raise the cap to five and render the unfixed findings as a section of the PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The whole-run final review in the built-in flows allowed three fix rounds, and the flows discarded the loop's result. A run could end with findings still open and open a PR that said nothing about them.
Changes
implement.sc,implement-interactive.sc,implement-enhanced.sc,issue-pr.scandissue-pr-bugfix.scnow allows five rounds. The per-task loop and the library default stay at three.renderOpenFindingsrenders the loop's unfixed findings as a markdown section, verbatim, omitted when there are none.openPrFromBranchtakes a requiredopenFindingsparameter and appends that section to the PR body. No default, so a flow cannot drop the loop's result by omission.Limitation
The loop returns only a title and reason per finding. Reviewer, location and suggestion are not retained, so they are not listed.
Note
Touches the same helper signature that #169 extends. Whichever lands second needs the pass-through added to
openPrIfGitHub.