Repository navigation
Frontend: announce payment confirmation, limit amount decimals, document locale and form-retention behavior - #927
Open
jhaydeeee-web wants to merge 4 commits into
Open
jhaydeeee-web wants to merge 4 commits into
jhaydeeee-web wants to merge 4 commits into
Conversation
|
@jhaydeeee-web Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #914
Closes #913
Closes #912
Closes #911
Summary
c030331: Announce payment confirmation to assistive technology (#914)
Added a persistent visually hidden
role="status"live region inInvoicePayment.tsxthat announces the payment success message when the receipt replaces the visible status message, which previously went unannounced.7a52f3d: Document and test fixed-locale token amount formatting (#913)
formatAmountinutils/format.tsalready uses an explicit locale (default en-US) rather than the browser locale, so only a maintainer note (docs/drips-notes/913-token-amount-locale.md) and a regression test (tests/formatLocale.test.ts) were added.b05cfd4: Limit invoice amount input to supported fractional digits (#912)
Added
limitFractionDigitsin the newutils/amountInput.tsand applied it in the amount branch ofhandleChangeinCreateInvoice.tsx, so input is truncated to the selected token's decimals. A unit test was added.a888235: Document invoice form preservation after API errors (#911)
CreateInvoicealready keeps the entered values whencreateInvoicefails, since onlyhandleResetclears them. Only a maintainer note (docs/drips-notes/911-invoice-form-preserved.md) was added.