Skip to content

Fix payment confirmation, modal focus, API URL, and empty error toasts - #928

Open
Valreb001 wants to merge 4 commits into
WHEELBACK:mainfrom
Valreb001:drips/valreb001-issues
Open

Valreb001 wants to merge 4 commits into
WHEELBACK:mainfrom
Valreb001:drips/valreb001-issues

Conversation

@Valreb001

Copy link
Copy Markdown
Contributor

Closes #926
Closes #925
Closes #924
Closes #923

Summary

7b159f2: Wait for ledger confirmation before showing payment success (#926)

  • Added waitForLedgerConfirmation in new utils/ledgerConfirmation.ts; payInvoice in utils/soroban.ts now polls getTransaction until SUCCESS before returning success.
  • A FAILED or timed-out transaction returns an error result instead of a premature success message.

5d8b400: Restore keyboard focus when the payment modal closes (#925)

  • useFocusTrap cleanup now retries focusing the trigger element after the DOM settles if the first attempt did not take.

25549ab: Resolve API base URL per request to avoid stale config (#924)

  • utils/api.ts replaces the module-level API_BASE constant with getApiBase(), read on every request.

d3f7fca: Fall back to a default message for empty API error notifications (#923)

  • ToastProvider.addToast in Toast.tsx substitutes a default message when the message is empty or not a string.
  • request in utils/api.ts only uses body.error when it is a non-empty string, otherwise the status-based message.

@drips-wave

drips-wave Bot commented Oct 17, 2026

Copy link
Copy Markdown

@Valreb001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant