Repository navigation
Conversation
|
@rdj-savyy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #922
Closes #921
Closes #920
Closes #919
Summary
4b19732: Show longer wallet address prefix and suffix so accounts are distinguishable (#922)
Added a
truncateAddresshelper inutils/truncateAddress.tsthat keeps 8 leading and 8 trailing characters, andWalletBar.tsxnow uses it instead of its 6/4 truncation. The existing WalletBar test expectation was updated accordingly.6b069b9: Block resubmitting a completed payment after browser back navigation (#921)
Added the
useCompletedPaymentGuardhook, which records paid invoice ids in sessionStorage.InvoicePayment.tsxhandleConfirmPaymentnow returns early for an already-paid invoice (or an in-flight submission) and marks the invoice completed after a successful payment.4858255: Time out invoice retrieval so the loading state always clears (#919)
loadInvoiceinhooks/useInvoice.tsnow races the fetch against a 30 second timeout, surfacing a timeout error and clearing the timer and loading flag in thefinallyblock.a3cd1d8: Clear cached invoice details when the connected account changes (#920)
useInvoiceaccepts an optional account key and resets the cached invoice and error when it changes.InvoicePayment.tsxpasses the connected wallet address to it.