Repository navigation
Wallet UX fixes: rejection handling, pending pay state, network refresh, dialog close on disconnect - #931
Open
Dev-makeem wants to merge 4 commits into
Open
Wallet UX fixes: rejection handling, pending pay state, network refresh, dialog close on disconnect#931Dev-makeem wants to merge 4 commits into
Dev-makeem wants to merge 4 commits into
Conversation
|
@Dev-makeem Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #910
Closes #909
Closes #908
Closes #907
Summary
bd8fcee: Show wallet rejection as a cancellation, not an app error (#910)
Added
utils/walletErrors.tswithisWalletRejectionandfriendlyWalletError, which map a user-declined wallet prompt to a neutral "Request cancelled in your wallet" message.payinhooks/useInvoice.tsnow passes thepayInvoiceresult through it.22acd66: Disable Pay Invoice button while a transaction is pending (#909)
The confirmation modal already disabled its buttons while submitting. The remaining gap was the "Pay Invoice" trigger button in
InvoicePayment.tsx, which now also disables whilesubmittingis true.c5cbcee: Refresh wallet network on window focus after switching (#908)
subscribeinhooks/useWallet.tsnow re-reads the account and network on window focus and when the tab becomes visible, so a network switch in Freighter is reflected right away instead of after the next 5 second poll. Listeners are removed on last unsubscribe.7cfc846: Close pay confirmation dialog when the wallet disconnects (#907)
PayConfirmationModal.tsxnow reads the shared wallet state and callsonCancelif the wallet becomes disconnected while the dialog is open and no payment is submitting.