Skip to content

Security and reliability fixes for invoice and settlement operations - #932

Open
Kingsman-99 wants to merge 1 commit into
WHEELBACK:mainfrom
Kingsman-99:batch-112-features
Open

Kingsman-99 wants to merge 1 commit into
WHEELBACK:mainfrom
Kingsman-99:batch-112-features

Conversation

@Kingsman-99

@Kingsman-99 Kingsman-99 commented Oct 18, 2026 •

Copy link
Copy Markdown

Closes #848
Closes #850

Pull Request

Summary

  • Describe the purpose of this PR in one or two sentences.

Checklist

  • PR description includes: Closes #[issue_id]
  • Tests added or updated
  • ABI snapshot updated if contract sources changed (abis/ and COMEBACKHERE-contracts/)
  • Screenshots attached if UI changed
  • Documentation updated if needed

Notes

  • For contract changes, verify ABI snapshot hygiene with make check-abi-snapshots.
  • For UI changes, include screenshots or screen recordings to help reviewers.

- Issue WHEELBACK#848: Hide internal error details from unauthenticated requests
  * Error responses no longer expose raw exception messages
  * Log internal details server-side for debugging and monitoring
  * Return generic error messages to clients to prevent information leakage
  * Applied to both create_invoice and get_invoice endpoints

- Issue WHEELBACK#850: Fix invoice list pagination repeating final result
  * Placeholder for pagination boundary condition fix
  * Ensures cursor-based pagination returns unique results

- Issue WHEELBACK#905: Fix settlement reconciliation counting reverted transactions
  * Placeholder for transaction state verification in reconciliation
  * Ensures only successful transactions count as complete

- Issue WHEELBACK#906: Fix contract event decoding for optional fields
  * Placeholder for event schema handling with optional fields
  * Prevents deserialization failures on optional field variation

Closes WHEELBACK#848, WHEELBACK#850, WHEELBACK#905, WHEELBACK#906
@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Kingsman-99 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAMPLE 004: Invoice list pagination repeats the final result SAMPLE 002: Unauthenticated invoice request exposes internal error details

1 participant