Skip to content

fix: resolve issues #883 #884 #885 #886 - #933

Open
villadel wants to merge 2 commits into
WHEELBACK:mainfrom
villadel:feat/issues-883-884-885-886
Open

villadel wants to merge 2 commits into
WHEELBACK:mainfrom
villadel:feat/issues-883-884-885-886

Conversation

@villadel

Copy link
Copy Markdown
Contributor

#886 — return tx_hash in error response for failed invoice creation

  • Attach tx_hash to thrown errors in createInvoice() for timeout, FAILED status and ERROR send result
  • Surface tx_hash in POST /invoices error JSON body so callers can identify orphaned contract records

#885 — use UTC timestamps instead of local time

  • Add formatUTC() helper in TransactionHistory.tsx
  • Replace toLocaleString() with ISO UTC string in both TransactionHistory and InvoicePayment expiry display

#884 — fix merchant invoice search ignoring status filter

  • Add normaliseStatus() helper in InvoiceSearchFilter.tsx
  • Use normalised string comparison to handle TypeScript string-enum vs string-union mismatch between comebackhere-frontend and frontend

#883 — add settlement transaction hash to receipt view

  • Add proposed_tx_hash and executed_tx_hash to Settlement type
  • Include both fields in GET /pending-settlements API response
  • Display them in SettlementDetail.tsx with monospace hash styling
  • Add .settlement-detail__value--hash CSS class

chore: expand .gitignore

  • Add test snapshots (snapshots/, *.snap)
  • Add Playwright reports, build outputs, TS/Vite cache
  • Add Cargo target/, OS noise, editor files, logs

Pull Request

Summary

  • Describe the purpose of this PR in one or two sentences.

Checklist

  • PR description includes: Closes #[issue_id]
  • Tests added or updated
  • ABI snapshot updated if contract sources changed (abis/ and COMEBACKHERE-contracts/)
  • Screenshots attached if UI changed
  • Documentation updated if needed

Notes

  • For contract changes, verify ABI snapshot hygiene with make check-abi-snapshots.
  • For UI changes, include screenshots or screen recordings to help reviewers.

closes
closes #883
closes #884
closes #885
closes #886

…CK#886

WHEELBACK#886 — return tx_hash in error response for failed invoice creation
  - Attach tx_hash to thrown errors in createInvoice() for timeout,
    FAILED status and ERROR send result
  - Surface tx_hash in POST /invoices error JSON body so callers can
    identify orphaned contract records

WHEELBACK#885 — use UTC timestamps instead of local time
  - Add formatUTC() helper in TransactionHistory.tsx
  - Replace toLocaleString() with ISO UTC string in both
    TransactionHistory and InvoicePayment expiry display

WHEELBACK#884 — fix merchant invoice search ignoring status filter
  - Add normaliseStatus() helper in InvoiceSearchFilter.tsx
  - Use normalised string comparison to handle TypeScript string-enum
    vs string-union mismatch between comebackhere-frontend and frontend

WHEELBACK#883 — add settlement transaction hash to receipt view
  - Add proposed_tx_hash and executed_tx_hash to Settlement type
  - Include both fields in GET /pending-settlements API response
  - Display them in SettlementDetail.tsx with monospace hash styling
  - Add .settlement-detail__value--hash CSS class

chore: expand .gitignore
  - Add test snapshots (__snapshots__/, *.snap)
  - Add Playwright reports, build outputs, TS/Vite cache
  - Add Cargo target/, OS noise, editor files, logs
@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@villadel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant