Repository navigation
Fix settlement reconciliation and contract event decoding issues - #934
Open
Kingsman-99 wants to merge 1 commit into
Open
Kingsman-99 wants to merge 1 commit into
Kingsman-99 wants to merge 1 commit into
Conversation
- Issue WHEELBACK#905: Settlement reconciliation counts reverted transaction as complete * Fixed get_pending_settlements to properly exclude Cancelled settlements * Reconciliation now only counts truly pending settlements * Prevents reverted/cancelled transactions from being counted as complete * Added clarifying comment on status filtering logic - Issue WHEELBACK#906: Contract event decoding fails for optional field * Added explicit handling in dispute_resolved event * Decoder must treat missing optional fields as None, not fail entire decode * Ensures event schema variations with optional fields are properly handled * Prevents event deserialization failures on optional field variation Closes WHEELBACK#905, WHEELBACK#906
|
@Kingsman-99 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue SAMPLE 059: Settlement reconciliation counts a reverted transaction as complete #905: Settlement reconciliation counts reverted transaction as complete
Issue SAMPLE 060: Contract event decoding fails for an optional field #906: Contract event decoding fails for optional field
Closes #905
Closes #906
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.