Repository navigation
Conversation
…perations - Issue WHEELBACK#868: Invoice creation rejects negative or zero amounts * Validate amount_usdc is greater than zero * Return 422 Unprocessable Entity with clear error message - Issue WHEELBACK#869: Invoice creation rejects unsupported token symbols * Whitelist supported tokens: USDC, XLM, native * Return 422 with list of supported tokens for unknown symbols - Issue WHEELBACK#870: Invoice lookup checks merchant authorization * Added authorization check to prevent data leakage * Ensures requesting merchant can only view their own invoices * Prevents unauthorized access to other merchants' records - Issue WHEELBACK#866: Deprecated endpoint returns proper deprecation response * Add Deprecation and Sunset HTTP headers per RFC 8594 * Include migration path and deprecation notice in response body * Ensure clients receive clear guidance on endpoint migration * Response format includes data wrapped with deprecation metadata Closes WHEELBACK#868, WHEELBACK#869, WHEELBACK#870, WHEELBACK#866
|
@thelux134 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue SAMPLE 022: Invoice creation accepts a negative amount #868: Invoice creation rejects negative or zero amounts
Issue SAMPLE 023: Unsupported token symbol is accepted during invoice creation #869: Invoice creation rejects unsupported token symbols
Issue SAMPLE 024: Invoice lookup returns another merchant's record #870: Invoice lookup checks merchant authorization
Issue SAMPLE 020: Deprecated endpoint returns a response incompatible with migration guidance #866: Deprecated endpoint returns proper deprecation response
Closes #866
Closes #868
Closes #869
Closes #870
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.