Repository navigation
Add CORS middleware (CorsLayer::permissive) to handle preflight requests for all allowed origins - #937
Open
edwardfavour998-code wants to merge 1 commit into
Conversation
- WHEELBACK#858: Add CORS middleware (CorsLayer::permissive) to handle preflight requests for all allowed origins - WHEELBACK#860: Standardize error codes across all routes - use HTTP status codes (400/403/404/422/500) instead of custom codes - WHEELBACK#861: Idempotency store and mechanism already properly implemented in all mutation endpoints (pay/cancel/refund) - WHEELBACK#862: Add validation in create_invoice to reject zero expiration time, ensuring due dates are valid Changes: - lib.rs: Import tower_http::cors::CorsLayer and add to router middleware - Cargo.toml: Add tower-http dependency with cors feature - routes/invoices.rs: Add expires_in_seconds validation, standardize error codes (403/404/422/500) - routes/pay.rs: Standardize error codes to match HTTP status (403/404/500) - routes/cancel.rs: Standardize error codes to match HTTP status (403/404/500) - routes/refund.rs: Standardize error codes (403/404/422/500)
|
@edwardfavour998-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #858
Closes #860
Closes #861
Closes #862
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.