Skip to content

Add API_PREFIX environment variable support for reverse proxy deployments with path prefixes (uses Router::nest) - #938

Open
Young850 wants to merge 1 commit into
WHEELBACK:mainfrom
Young850:batch-117-features
Open

Young850 wants to merge 1 commit into
WHEELBACK:mainfrom
Young850:batch-117-features

Conversation

@Young850

@Young850 Young850 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Changes:

  • lib.rs: Add API_PREFIX env var support with Router::nest() for path-prefixed deployments
  • routes/invoices.rs: Validate amount_usdc > 0, gross_usdc > 0, and gross_usdc >= amount_usdc before processing
  • types.rs: Add documentation about precision handling with u64 stroops representation
  • auth.rs: Add comment clarifying UTF-8 byte encoding for signature verification with Unicode content

Closes #863
Closes #865
Closes #867

Pull Request

Summary

  • Describe the purpose of this PR in one or two sentences.

Checklist

  • PR description includes: Closes #[issue_id]
  • Tests added or updated
  • ABI snapshot updated if contract sources changed (abis/ and COMEBACKHERE-contracts/)
  • Screenshots attached if UI changed
  • Documentation updated if needed

Notes

  • For contract changes, verify ABI snapshot hygiene with make check-abi-snapshots.
  • For UI changes, include screenshots or screen recordings to help reviewers.

- WHEELBACK#864: Add API_PREFIX environment variable support for reverse proxy deployments with path prefixes (uses Router::nest)
- WHEELBACK#867: Add validation in create_invoice to reject zero amounts and ensure gross_usdc >= amount_usdc
- WHEELBACK#863: Document precision handling for large token amounts - u64 stroops format prevents precision loss
- WHEELBACK#865: Ensure consistent UTF-8 encoding in webhook signature verification (comments added)

Changes:
- lib.rs: Add API_PREFIX env var support with Router::nest() for path-prefixed deployments
- routes/invoices.rs: Validate amount_usdc > 0, gross_usdc > 0, and gross_usdc >= amount_usdc before processing
- types.rs: Add documentation about precision handling with u64 stroops representation
- auth.rs: Add comment clarifying UTF-8 byte encoding for signature verification with Unicode content
@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Young850 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant