Repository navigation
Conversation
- WHEELBACK#864: Add API_PREFIX environment variable support for reverse proxy deployments with path prefixes (uses Router::nest) - WHEELBACK#867: Add validation in create_invoice to reject zero amounts and ensure gross_usdc >= amount_usdc - WHEELBACK#863: Document precision handling for large token amounts - u64 stroops format prevents precision loss - WHEELBACK#865: Ensure consistent UTF-8 encoding in webhook signature verification (comments added) Changes: - lib.rs: Add API_PREFIX env var support with Router::nest() for path-prefixed deployments - routes/invoices.rs: Validate amount_usdc > 0, gross_usdc > 0, and gross_usdc >= amount_usdc before processing - types.rs: Add documentation about precision handling with u64 stroops representation - auth.rs: Add comment clarifying UTF-8 byte encoding for signature verification with Unicode content
|
@Young850 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #863
Closes #865
Closes #867
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.