Repository navigation
fix: resolve issues #878, #880, #881, #882 - #985
Open
kurehkim334-lang wants to merge 1 commit into
Open
kurehkim334-lang wants to merge 1 commit into
kurehkim334-lang wants to merge 1 commit into
Conversation
…LBACK#882 WHEELBACK#878 — formatAmount: clamp minimumFractionDigits to fractionDigits not maximumFractionDigits, preventing spurious decimal zeros on 0-decimal tokens when maximumFractionDigits is explicitly set. WHEELBACK#880 — GET /invoices/:id and GET /invoices/:id/events: normalise the route parameter with String(BigInt(id)) to strip leading zeros so that '042' and '42' resolve to the same invoice document in MongoDB. WHEELBACK#881 — indexer recordTransition: move persistTransition() call to after the applied:true write so that any future side-effects (webhooks) only fire once the invoice status is durably stored. Previously a crash between the webhook dispatch and the DB mark would replay the webhook. WHEELBACK#882 — soroban.ts (frontend) buildAndSend: validate the signed transaction's network passphrase against VITE_NETWORK_PASSPHRASE before submitting; throws a clear 'Network mismatch' error when the wallet is on the wrong network. Backend createInvoice: reject an empty or missing networkPassphrase with a 503 to prevent network-agnostic transactions. Tests added for all four fixes.
|
@kurehkim334-lang Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#878 — formatAmount: clamp minimumFractionDigits to fractionDigits not maximumFractionDigits, preventing spurious decimal zeros on 0-decimal tokens when maximumFractionDigits is explicitly set.
#880 — GET /invoices/:id and GET /invoices/:id/events: normalise the route parameter with String(BigInt(id)) to strip leading zeros so that '042' and '42' resolve to the same invoice document in MongoDB.
#881 — indexer recordTransition: move persistTransition() call to after the applied:true write so that any future side-effects (webhooks) only fire once the invoice status is durably stored. Previously a crash between the webhook dispatch and the DB mark would replay the webhook.
#882 — soroban.ts (frontend) buildAndSend: validate the signed transaction's network passphrase against VITE_NETWORK_PASSPHRASE before submitting; throws a clear 'Network mismatch' error when the wallet is on the wrong network. Backend createInvoice: reject an empty or missing networkPassphrase with a 503 to prevent network-agnostic transactions.
Tests added for all four fixes.
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.closes
closes #878
closes #880
closes #881
closes #882