Repository navigation
fix: resolve issues #891, #892, #893, #894 - #994
Open
ahmadadebayo78-boop wants to merge 1 commit into
Open
ahmadadebayo78-boop wants to merge 1 commit into
ahmadadebayo78-boop wants to merge 1 commit into
Conversation
…LBACK#894 WHEELBACK#893 — compliance.ts: import cacheDelete and call it after both /compliance/allow and /compliance/block succeed so the stale compliance:status:{address} cache entry is evicted immediately. WHEELBACK#891 — treasury.ts: after executeSettlementWithBalanceCheck returns a confirmed tx_hash, updateOne the settlement document to status=Executed + executed_tx_hash so it no longer stays Pending. WHEELBACK#894 — treasury.ts: remove the try/catch that swallowed errors from executeSettlementWithBalanceCheck and re-emitted them as HTTP 4xx/5xx JSON responses — this masked FAILED contract transactions as apparent successes. Errors now propagate through asyncHandler to the central error middleware. Also replace the broken res.locals.logger reference in the standalone helper function with the module-level logger import. WHEELBACK#892 — invoices.ts: before calling createInvoice, look up the most recent compliance audit record for the merchant address; if the latest event is address_blocked, throw a 403 ForbiddenError so compliance- rejected addresses cannot initiate invoice payments. Adds the missing requireMerchantApiKey import and ForbiddenError / compliance collection imports required by this guard. .gitignore: add *.orig, *.bak, *.rej, .node_repl_history, Thumbs.db:encryptable, ehthumbs.db, Desktop.ini, Python __pycache__ and bytecode patterns.
|
@ahmadadebayo78-boop Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#893 — compliance.ts: import cacheDelete and call it after both /compliance/allow and /compliance/block succeed so the stale compliance:status:{address} cache entry is evicted immediately.
#891 — treasury.ts: after executeSettlementWithBalanceCheck returns a confirmed tx_hash, updateOne the settlement document to status=Executed + executed_tx_hash so it no longer stays Pending.
#894 — treasury.ts: remove the try/catch that swallowed errors from executeSettlementWithBalanceCheck and re-emitted them as HTTP 4xx/5xx JSON responses — this masked FAILED contract transactions as apparent successes. Errors now propagate through asyncHandler to the central error middleware. Also replace the broken res.locals.logger reference in the standalone helper function with the module-level logger import.
#892 — invoices.ts: before calling createInvoice, look up the most recent compliance audit record for the merchant address; if the latest event is address_blocked, throw a 403 ForbiddenError so compliance- rejected addresses cannot initiate invoice payments. Adds the missing requireMerchantApiKey import and ForbiddenError / compliance collection imports required by this guard.
.gitignore: add *.orig, *.bak, *.rej, .node_repl_history, Thumbs.db:encryptable, ehthumbs.db, Desktop.ini, Python pycache and bytecode patterns.
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.closes SAMPLE 045: Settlement status remains pending after ledger confirmation #891
closes SAMPLE 046: Compliance rejection does not prevent invoice payment #892
closes SAMPLE 047: Compliance status cache is not invalidated after an update #893
closes SAMPLE 048: Contract error is reported as a successful settlement #894