Repository navigation
Fix task control and resource monitoring for 0.40.1 - #20
Merged
Merged
Conversation
LingzheZhao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic authorization allowed users to control other users’ notebooks, shells, commands, TensorBoards, experiments, and queued jobs. Enforce owner/admin checks across individual and bulk operations, preflight job-queue batches before any mutation, and hide unavailable controls in the WebUI.
Restore allocation/container/runtime/GPU metric mappings when the master recovers running tasks. Registration and teardown remain balanced across duplicate events and multiple resources, so resource charts keep updating after a master restart.
Expose task measurements through
/api/v1/tasks/{task_id}/resources, with typed samples, generated Python/TypeScript clients, and the bundled REST reference. Preserve the existing WebUI API, fix internal documentation links, and prepare concise 0.40.1 notes and stable-release publishing.Validation: targeted backend tests with PostgreSQL 14 and Go race detection; focused WebUI permission/action tests and TypeScript checks; actionlint. The Actions-built candidate passed real HTTP ownership/bulk-control checks, metrics and documentation checks, and a running CPU task across image replacement and another master restart. The task kept its container and start time, metric mappings recovered exactly once, and termination cleared them without negative counts.