Repository navigation
fix: harden fork maintenance and use manual candidate builds - #3
Merged
Merged
Conversation
LingzheZhao
added a commit
that referenced
this pull request
Sep 28, 2026
Trials and Generic Tasks can now open a task/allocation resource dashboard backed by the existing cluster-setup Prometheus/Grafana stack. The integration is opt-in via `integrations.grafana_task_resources` and disabled by default. A small authenticated UI configuration route returns only the validated dashboard URL and cluster selector. Trial details and the shared task logs page pass the real task ID, optional single allocation, and task start/end timestamps to dashboard UID `det-task-resources`. All allocations use Grafana's `$__all`; running tasks use `to=now`. URL encoding preserves Grafana subpaths, and unsafe schemes/embedded credentials are rejected. Cookie-only sessions work, unavailable optional configuration leaves task management intact, and navigation clears stale task metadata. Generic Tasks currently have no dedicated details/Job Queue page; the existing `/det/generic/<task-id>/logs` route provides the entry. Grafana permissions remain independent; this change does not introduce a resource query API or claim per-task isolation in Grafana. Validation: Go config tests (including recursive integration validation), master/internal compilation, Node 20.20.2 focused URL tests (3), full TypeScript check, focused ESLint/Prettier/Stylelint and diff checks passed. The companion provisioned dashboard was exercised through real Prometheus/Grafana with synthetic data and visually checked in a browser. No Actions run was triggered. Actual lab exporter access and production enablement remain pending; the integration stays off until configured. Companion: [cluster-setup PR #3](WU-CVGL/cluster-setup#3) supplies collection fixes, identity rules, task dashboard and scrape credential migration. One coherent PR per repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the original merge of #2 with a GitHub squash merge, as requested by the project owner. This retains task-control authorization and archive-extraction fixes, standalone candidate packaging, and local-first checks. GitHub Actions retains only the manually dispatched distribution build.
The complete source tree is identical to the original maintenance head
4a0d27bcd79f1d16a25342495a724a87b847d130. Its workstation acceptance passed: exact-source Linux builds and wheel, real static CPU task, core task-control authorization regression, 1 quick regression, and 27 archive tests. Full evidence and artifact-reuse limits remain recorded in #2. This history rewrite changes no product files and does not require repeating those tests.The original merge commits are being replaced in maintenance-then-pools order. The previous main tip is preserved locally at
codex/backup-main-before-squash-20260920.