Skip to content

fix: select runner image by exact alias match (#86) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jchak7 wants to merge 3 commits into from
Closed

fix: select runner image by exact alias match (#86) #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e2955
fix: select runner image by exact alias match (#86)
jchak7 Sep 1, 2026
20ce4e6
chore: rebuild dist for exact alias match fix
jchak7 Sep 1, 2026
8457870
chore: rebuild dist after rebase on main
jchak7 Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 16 additions & 6 deletions src/snapshotter/snapshotter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,18 @@ echo "Presave complete"
let nextVersionID = 0
this.logger.debug('Found the following runner images:')
this.logger.debug(JSON.stringify(images, null, 2))
if ((images.runner_images?.length ?? 0) > 0) {

// The list endpoint can return aliases that merely contain the requested
// one (e.g. querying 'my-image' also matches 'my-image-arm64'), and the
// order of those results is not guaranteed. Pick the exact match rather
// than trusting the first element — otherwise which alias "wins" varies
// from run to run, and we can update the wrong image or fail with a
// spurious arch/os mismatch.
const existingImage = images.runner_images?.find(
image => image.alias === opts.runnerImageAlias
)

if (existingImage) {
this.logger.info(
`Snapshot alias '${opts.runnerImageAlias}' already exists`
)
Expand All @@ -255,11 +266,10 @@ echo "Presave complete"
opts.runnerImageAlias
}' to new snapshot`
)
runnerImageID = images.runner_images?.[0].id || ''
const existingArch = images.runner_images?.[0].arch
const existingOs = images.runner_images?.[0].os
versionID =
images.runner_images?.[0].warpbuild_snapshot_image?.version_id ?? 0
runnerImageID = existingImage.id || ''
const existingArch = existingImage.arch
const existingOs = existingImage.os
versionID = existingImage.warpbuild_snapshot_image?.version_id ?? 0
nextVersionID = versionID + 1
if (existingArch !== currArch) {
throw new Error(
Expand Down
Loading