chore: remove deprecated wasmedge_llmc plugin (#36)#51
Open
0yi0 wants to merge 1 commit into
Open
Conversation
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Upstream deprecated the wasmedge_llmc plugin (WasmEdge/WasmEdge#4964). Rather than migrate it into cpp-plugins, remove it: drop the residual plugins/wasmedge_llmc and test/plugins/wasmedge_llmc directories and the add_subdirectory stanzas in plugins/CMakeLists.txt and test/plugins/CMakeLists.txt. libpiper (wasi_nn) is unrelated and kept. Rebased onto main after the refresh re-import (#50), whose upstream deprecation commit had already emptied the plugin to stub CMakeLists. Closes #36 Signed-off-by: Yi Huang <yi@secondstate.io> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Remove the
wasmedge_llmcplugin. Upstream deprecated it (WasmEdge/WasmEdge#4964); rather than migrate it into cpp-plugins, we drop it. Closes #36. Decision flagged in #36 / #22.Rebased onto
mainafter the refresh re-import #50 merged — that re-import carried upstream's deprecation commit, which had already emptied the plugin down to stubCMakeLists.txtfiles. This PR removes those residuals and the build wiring.Implementation design
git rm -r plugins/wasmedge_llmc test/plugins/wasmedge_llmc— on currentmainthese dirs contain only the residual stubCMakeLists.txt(source already removed upstream via chore: refresh imported plugin sources from upstream 0.17.0-131 (#45) #50).if(WASMEDGE_PLUGIN_LLMC) add_subdirectory(wasmedge_llmc)stanza fromplugins/CMakeLists.txtandtest/plugins/CMakeLists.txt.libpiperis intentionally untouched — it belongs towasi_nn(utils/wasi-nn/,utils/build_libpiper.sh), not llmc.Design decisions
wasmedge_llmc/WASMEDGE_PLUGIN_LLMC/wasmedgePluginWasmEdgeLLMCall gone).Commit slicing
Single authored commit:
chore: remove deprecated wasmedge_llmc plugin (#36).Test plan
wasmedge_llmc/WASMEDGE_PLUGIN_LLMCreferences in the treelibpiper/ wasi_nn files intactmain; clean (no conflicts)Non-goals / afterwards
option(WASMEDGE_PLUGIN_LLMC ...)declaration removal lives in WasmEdge core → epic tracking: remove migrated plugins from WasmEdge core #28🤖 Generated by Claude Opus 4.8 (1M context) with Claude Code