Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates WeakAuras for the current Classic client APIs and expands Health trigger functionality.
Replaces deprecated APIs for aura queries, spellbook checks, specialization, combat logs, chat, action bars, and item information.
Extends the aura sandbox restrictions to additional destructive functions and their namespaced equivalents.
Enables absorb and heal-absorb values and overlays across client flavors, alongside existing incoming-heal support.
Fixes the heal-absorb overlay using the absorb setting instead of its own setting.
Prepares commented-out encounter lists for future Titan phases.
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
How Has This Been Tested
Reviewed migrated API arguments and return values against Warcraft Wiki and Blizzard UI sources for current Era, TBC, Mists, and Titan.
In-game validation of triggers, overlays, and chat-link
Note
BuffTrigger could probably use now the
newApithat was used for only Retail, i did not switch the system since it is not used for longer now.