Conversation
…ic home An authenticated user should land on a dashboard, not the public marketing/home page. _roleHome already sends admin roles to /admin; it was sending everyone else to '/' (the public home — which, with the CMS home-page selector pointing / at a theme page, is whatever marketing/landing is set). Non-admin authenticated users now land on /account (the "My Account" dashboard, AccountController) — guests still see '/'. Fixes a signed-in `user` being dropped on the public home after login. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AuthController::_roleHome()sends admin roles →/adminand everyone else →/account(was/).Why
An authenticated user should land on a dashboard, not the public home. Since the CMS home-page
selector (1.16.0) can point
/at any theme's landing page, a signed-in non-admin was being dropped onthe marketing/landing page after login (e.g. a leftover
@theme:grey-misthome)./account(
core/controllers/AccountController.php— "the authenticated NON-admin home, My Account") is theproper destination; guests still see
/.Applies to both redirect paths that use
_roleHome— the already-signed-in GET redirect and thesuccessful-login JSON redirect.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ