Add event reminder notification features - #24
Merged
Merged
Conversation
- Implemented the `fetch_event_reminder_targets` function in the backend client to retrieve reminder notification targets. - Added schemas for event reminders, including `EventReminderTargetsResponse`. - Created functions for building and sending event reminder notifications, including `build_event_reminder_notification_data` and `send_event_reminder_push_notification`. - Introduced unit tests for the new event reminder functionalities, ensuring proper response parsing and payload structure. - Updated event notification processing to handle reminders, including idempotency key management for reminders. - Enhanced SQS message parsing to support event reminders with appropriate validation.
- Enhanced the `fetch_event_reminder_targets` function to accept an optional `fire_at` parameter, allowing the backend to differentiate between stale and fresh reminder messages. - Updated the `_fetch_all_reminder_targets` and `_process_event_reminder` functions to handle the new `fire_at` parameter. - Modified the event notification message processing to forward the `fire_at` value when present, ensuring compatibility with older message formats. - Added unit tests to verify the correct handling of the `fire_at` parameter in reminder notifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_event_reminder_targetsfunction in the backend client to retrieve reminder notification targets.EventReminderTargetsResponse.build_event_reminder_notification_dataandsend_event_reminder_push_notification.