Repository navigation
feat: update material system and add new shadcn components - #27
Conversation
Deploying sistine with
|
| Latest commit: |
b287793
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://079f1094.sistine.pages.dev |
| Branch Preview URL: | https://weekendsuperhero-clean-up-co.sistine.pages.dev |
🤖 Muse — Test Coverage · ✅ passRound 3 · reviewed Summary: The pull request successfully addresses the remaining test coverage gaps. Both the combobox multiple selection chips and the carousel reduced motion behavior are now covered by automated tests. ✅ Resolved this round (2)
Re-run: add the |
🤖 Muse — Security · ✅ passRound 3 · reviewed Summary: The PR introduces frontend UI components, styling refinements, and tests. URL query parameters in BackdropScene are strictly validated against hardcoded allowlists, preventing injection. No XSS vulnerabilities, exposed secrets, or unsafe input handling were identified. Re-run: add the |
…ove buttons Addresses the Muse test-coverage review (TST-2-1, TST-2-2): - combobox: multiple-selection tests (chips render, a chip's remove button removes its value, choosing an option adds a chip) - carousel: autoplay advances when motion is allowed and never advances, with no pause control, under prefers-reduced-motion The chip test surfaced an unnamed icon-only remove button: ComboboxChip now labels it "Remove <value>" (or `removeLabel`), as Base UI sets no name.
🤖 Muse — Code Review · ✅ passRound 3 · reviewed Summary: The test coverage for combobox chips and carousel reduced motion is solid. The logic for naming the chip remove buttons gracefully handles string and number children, ensuring correct ARIA labels. No issues found. Re-run: add the |
Summary
Changes
Theme & Material System
glass,frosted,crystal, andopaquematerials.borderColor="ink"axis to draw borders in the element's text color.engine.css,materials.css) to properly compose scoped gloss and fix cascade issues.lapispreset and fixedselenite/moonstonetint anchors.New Components
Combobox(powered by@base-ui/react),Empty,Field,Item,Kbd,Menubar, andProgress.Component Fixes
ResizeObserverfeedback loops and unmounted 0x0 hidden tab issues.DialogBodyto restrict scrolling to the body while keeping headers/footers fixed.data-[disabled]selector bug that prevented mouse clicks on enabled items.DropdownMenuSubContentandContextMenuSubContentso glassbackdrop-filterdoesn't clip them.Toasterto beunstyledand utilize theglassMaterialAPI directly.overflow-hiddenwithoverflow-clipto prevent sticky headers from scrolling incorrectly.speed 0and reduced motion toanimation: noneto stop off-screen compositor rendering.Test plan
Commandentries are fully clickable via mouse.DropdownMenu,ContextMenu,Menubar) break out of their parent containers without clipping.ChartContainerno longer spams ResizeObserver warnings in the console.Dialogwith tall content to confirm the header and footer remain fixed.Sonnertoasts apply semantic status tints properly (success, error, warning, info).PR description generated by Agent