Repository navigation
ci: stop deploying demo book to GitHub Pages - #165
Merged
Merged
Conversation
The template repo has no use for a hosted demo site; generated projects deploy their own via book.yml. The deployed site also showed MyST's BASE_URL banner because the build never set BASE_URL. Remove the Pages upload step, the deploy job, the pages/id-token permissions and the pages concurrency group, and rename the workflow to test-template. Keep the book build as a smoke test for generated projects. Closes #164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
deployjob from.github/workflows/test.yml; the template repo no longer publishes a demo site (it showed MyST's BASE_URL banner because the build never setBASE_URL)permissionstocontents: readand remove thepagesconcurrency group in.github/workflows/test.yml; both only served the deploymenttest-template-and-deploy-demo→test-template{{ cookiecutter.project_name }}/.github/workflows/book.yml(already setsBASE_URL)Related issues
Closes #164