Repository navigation
fix(auth-next): keep the cookie when a fetch's refresh fails - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4.
When a refresh fails on a spent token,
createAuthMiddlewarenow only signs out on a navigation. A fetch gets the same redirect tologinPath, but its response no longer expires the cookie, since a request beside it may be writing freshly rotated tokens to that cookie at the same moment. The next navigation retries with whatever the cookie holds by then, and clears it if that refresh fails too.packages/auth-next/src/middleware.ts: thecatcharoundrefreshAccessTokenpickssignOut()or a plain redirect byisNavigation.