Skip to content

fix(editor): synchronize dynamic dialogs and scope UI validation - #60

Merged
FLwolfy merged 4 commits into
masterfrom
fix/editor-dynamic-dialogs
Oct 31, 2026
Merged

FLwolfy merged 4 commits into
masterfrom
fix/editor-dynamic-dialogs

Conversation

@FLwolfy

@FLwolfy FLwolfy commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Current-frame dialog measurement replaces previous-frame auto-height sizing. Script reload, sample import and export expose coherent operation snapshots; cancellation and late progress stay with their original owner. Shared dialog controls keep wrapping, one scrolling body and reachable actions consistent. Indeterminate activity stops when export work has actually retired.

CI now selects a bounded Editor profile from the complete PR diff. It retains real Debug/native smoke, relevant ordinary/isolated suites, architecture and Wiki checks, while omitting Release, AOT restore, ten hot builds, unrelated complete suites and Player Support Pack generation. SDK/build/platform/backend/unknown changes and explicit manual requests retain full verification.

Local verification:

  • Official Editor Debug: zero warnings/errors; 73 native UI cases, 12 additional hot-path cases, five export/retirement cases and Shader Check passed.
  • Seven process-isolated scripting/sample/retirement regressions and formal Canvas/Rendering2D/FlappyBird IDE projections passed.
  • Architecture evaluated 241/241 projects; 198 Wiki examples compiled without errors.
  • Independent FlappyBird copy completed eight workflows and 15,000 frames with clean exit.
  • Four dialog workloads each ran five paired 100,000-frame samples. Final CPU/P95 median and paired-median changes stay below 10%; managed allocations decrease 2.2–7.6%. Earlier failed samples remain available.
  • Twenty CI policy cases passed; the actual branch diff selects Editor verification.

Acceptance, ownership review and limitations · Raw performance evidence

BGCS remains 4.1.2, with no BGCS source/package, vendor or generated-binding edits. The deployed runtime hash matches the restored package. This does not implement Support Pack stage telemetry (#57) or claim that general engine sluggishness is resolved.

The first scoped macOS run exposed missing Wiki fixture references. The final filter builds 169 production and 13 test-support contracts, while keeping unrelated executable suites excluded. Wiki validation is unchanged.

Final CI at 8c6694ba05f4acc5ca43e75c63f34aec2a4c45d4:

  • Engine CI: Windows x64 and macOS ARM64 passed real Debug/native renderer smoke, scoped contracts/workflows, architecture and compiled Wiki checks. The full managed matrix, Release, repeated cache acceptance and Support Pack generation were intentionally skipped.
  • Windows evidence · macOS evidence.
  • Dependency graph CI and the automatic NuGet submission check passed.

The committed local report was sealed before CI completed; this final-head confirmation supersedes its pending-CI status. Cold native work still takes time: Windows Debug native build was 39m09s and related suites about 38m24s. No unmeasured speedup factor is claimed.

Physical macOS/display experience and the unrelated full Player/Browser deployment matrix were not rerun. All four commits use Aaron Liao as author and committer, without a co-author. Issues remain open until this PR merges; no automatic merge is requested.

Fixes #58
Fixes #59

@FLwolfy
FLwolfy marked this pull request as ready for review October 31, 2026 04:58
@FLwolfy
FLwolfy merged commit a08f87e into master Oct 31, 2026
6 checks passed
@FLwolfy
FLwolfy deleted the fix/editor-dynamic-dialogs branch October 31, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(validation): select checks from affected engine areas fix(editor): keep dynamic dialog layout and status snapshots consistent

1 participant