Repository navigation
fix(editor): synchronize dynamic dialogs and scope UI validation - #60
Merged
Merged
Conversation
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current-frame dialog measurement replaces previous-frame auto-height sizing. Script reload, sample import and export expose coherent operation snapshots; cancellation and late progress stay with their original owner. Shared dialog controls keep wrapping, one scrolling body and reachable actions consistent. Indeterminate activity stops when export work has actually retired.
CI now selects a bounded Editor profile from the complete PR diff. It retains real Debug/native smoke, relevant ordinary/isolated suites, architecture and Wiki checks, while omitting Release, AOT restore, ten hot builds, unrelated complete suites and Player Support Pack generation. SDK/build/platform/backend/unknown changes and explicit manual requests retain full verification.
Local verification:
Acceptance, ownership review and limitations · Raw performance evidence
BGCS remains 4.1.2, with no BGCS source/package, vendor or generated-binding edits. The deployed runtime hash matches the restored package. This does not implement Support Pack stage telemetry (#57) or claim that general engine sluggishness is resolved.
The first scoped macOS run exposed missing Wiki fixture references. The final filter builds 169 production and 13 test-support contracts, while keeping unrelated executable suites excluded. Wiki validation is unchanged.
Final CI at
8c6694ba05f4acc5ca43e75c63f34aec2a4c45d4:The committed local report was sealed before CI completed; this final-head confirmation supersedes its pending-CI status. Cold native work still takes time: Windows Debug native build was 39m09s and related suites about 38m24s. No unmeasured speedup factor is claimed.
Physical macOS/display experience and the unrelated full Player/Browser deployment matrix were not rerun. All four commits use Aaron Liao as author and committer, without a co-author. Issues remain open until this PR merges; no automatic merge is requested.
Fixes #58
Fixes #59