PHPStan: correct includes/acf-field-functions.php #52

Activity

1. kraftbj

   added a parent issue on Mar 4, 2025

   • PHP Stan Results #49
2. kraftbj

   changed the title [-]'#^@param array \$sub_field does not accept actual type of parameter\: int\|false\.$#'[/-] [+]PHPStan: correct includes/acf-field-functions.php[/+] on Mar 4, 2025
3. kraftbj

   added the

   Bug

   issue type on Mar 14, 2025
4. pkevan commented on Apr 23, 2025

   

   pkevan

   on Apr 23, 2025

   Contributor

   More actions

   Started looking at these in an attempt to clear out some issues, and in this particular one, the hardest one to fix is:

   message: '#^Action callback returns array but should not return anything\.$#'
   			identifier: return.void
   			count: 1
   			path: ../includes/acf-field-functions.php
   

   which relates to (

   secure-custom-fields/includes/acf-field-functions.php

   Lines 293 to 334 in 10d896b

   	/**
   	* acf_translate_field
   	*
   	* Translates a field's settings.
   	*
   	* @date 8/03/2016
   	* @since ACF 5.3.2
   	*
   	* @param array $field The field array.
   	* @return array
   	*/
   	function acf_translate_field( $field = array() ) {
   	// Get settings.
   	$l10n = acf_get_setting( 'l10n' );
   	$l10n_textdomain = acf_get_setting( 'l10n_textdomain' );
   	// Translate field settings if textdomain is set.
   	if ( $l10n && $l10n_textdomain ) {
   	$field['label'] = acf_translate( $field['label'] );
   	$field['instructions'] = acf_translate( $field['instructions'] );
   	/**
   	* Filters the $field array to translate strings.
   	*
   	* @date 12/02/2014
   	* @since ACF 5.0.0
   	*
   	* @param array $field The field array.
   	*/
   	$field = apply_filters( 'acf/translate_field', $field );
   	}
   	// Return field.
   	return $field;
   	}
   	// Register variation.
   	acf_add_filter_variations( 'acf/translate_field', array( 'type' ), 0 );
   	// Translate fields passing through validation.
   	add_action( 'acf/validate_field', 'acf_translate_field' );

   ). the easy fix would be to avoid having a return in the function, but I'm hesitant to change that since other themes could be reliant on that function.

   function _acf_translate_field( $field = array() ) {
   	acf_translate_field( $field );
   }
   
   // Translate fields passing through validation.
   add_action( 'acf/validate_field', '_acf_translate_field' );
   

   Thoughts?
5. kraftbj commented on Apr 23, 2025

   

   kraftbj

   on Apr 23, 2025

   ContributorAuthor

   More actions

   I've seen this elsewhere is the original code. They're using add_action when they're treating it as add_filter. Behind the scenes, it all works (e.g. apply_filters will run things added via add_action), but it's not correct.

   I only glanced at it, but my suggestion is updating it to add_filter on 334.
6. pkevan commented on Apr 23, 2025

   

   pkevan

   on Apr 23, 2025

   Contributor

   More actions

   updating it to add_filter on 334.

   🤦 of course - spent too long looking at it to not see that!

   😄React with 😄1Reacted by Brandon Kraft
7. pkevan

   closed this as completedin #116on Apr 23, 2025