fix: Update SidePanel to use sidebarLeft icon - #4071
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe PR upgrades Canvas icon and token packages across package manifests. It changes ChangesSidePanel icon alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
ISSUE-4069
|
| Run status |
|
| Run duration | 02m 24s |
| Commit |
|
| Committer | Alan B Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
17
|
|
|
0
|
|
|
809
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.56%
|
|
|---|---|
|
|
1536
|
|
|
371
|
Accessibility
99.44%
|
|
|---|---|
|
|
5 critical
5 serious
0 moderate
2 minor
|
|
|
68
|
There was a problem hiding this comment.
Pull request overview
This PR updates the React SidePanel toggle button to use the newer sidebarLeftIcon (aligning the component with the v15 Figma spec) and bumps Canvas system icon + token dependencies to newer versions used across the repo.
Changes:
- Updated
SidePanel.ToggleButtondefault icon fromextendIcontosidebarLeftIconand simplified the transform logic. - Bumped
@workday/canvas-system-icons-webto4.2.0across packages. - Promoted
@workday/canvas-tokens-webfrom4.4.0-beta.0to stable4.4.0across packages.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Locks updated dependency versions (icons/tokens) and related deduping. |
| package.json | Bumps root dependencies for system icons and tokens. |
| modules/styling/package.json | Aligns styling package dependencies to updated icons/tokens versions. |
| modules/styling-transform/package.json | Aligns styling-transform dependencies to stable tokens. |
| modules/react/side-panel/lib/SidePanelToggleButton.tsx | Switches default icon to sidebarLeftIcon and updates transform logic for origin handling. |
| modules/react/package.json | Aligns React package dependencies to updated icons/tokens versions. |
| modules/preview-react/package.json | Aligns preview-react dependencies to updated icons/tokens versions. |
| modules/labs-react/package.json | Aligns labs-react dependencies to updated icons/tokens versions. |
| modules/docs/package.json | Aligns docs package dependencies to updated icons/tokens versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| }, | ||
| origin: { | ||
| start: {}, |
Summary
Fixes: #4069
sidebarLeftIconThe SidePanel component doesn't match our latest v15 Figma, so we're updating it.
Release Category
Components
Release Note
This update will break any visual snapshots as the icon has changed from
extendIcontosidebarLeftIcon. It is safe to accept these visual changes. The icon also no longer flips on expand / collapse, but it will still respect end (right) origin and RTL.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)
Summary by CodeRabbit
Bug Fixes
Chores