Skip to content

fix: Update SidePanel to use sidebarLeft icon - #4071

Merged
alanbsmith merged 2 commits into
Workday:supportfrom
alanbsmith:ISSUE-4069
Aug 5, 2026
Merged

fix: Update SidePanel to use sidebarLeft icon#4071
alanbsmith merged 2 commits into
Workday:supportfrom
alanbsmith:ISSUE-4069

Conversation

@alanbsmith

@alanbsmith alanbsmith commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

Fixes: #4069

  • Bump canvas-system-icons-web to v4.2.0 (we didn't need to do this, but I went ahead with it to keep us current).
  • Update SidePanel to use sidebarLeftIcon

The SidePanel component doesn't match our latest v15 Figma, so we're updating it.

Release Category

Components

Release Note

This update will break any visual snapshots as the icon has changed from extendIcon to sidebarLeftIcon. It is safe to accept these visual changes. The icon also no longer flips on expand / collapse, but it will still respect end (right) origin and RTL.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Summary by CodeRabbit

  • Bug Fixes

    • Improved side panel toggle behavior and icon direction handling.
    • Updated the default toggle icon for clearer panel expansion controls.
  • Chores

    • Updated system icons to version 4.2.0.
    • Upgraded design tokens from the beta release to stable version 4.4.0 across packages.

@alanbsmith
alanbsmith requested a review from a team as a code owner July 16, 2026 22:39
@alanbsmith alanbsmith added the ready for review Code is ready for review label Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e9626b7-da85-42d3-87fa-cad339602168

📥 Commits

Reviewing files that changed from the base of the PR and between 23b7a01 and a0926b7.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (8)
  • modules/docs/package.json
  • modules/labs-react/package.json
  • modules/preview-react/package.json
  • modules/react/package.json
  • modules/react/side-panel/lib/SidePanelToggleButton.tsx
  • modules/styling-transform/package.json
  • modules/styling/package.json
  • package.json

📝 Walkthrough

Walkthrough

The PR upgrades Canvas icon and token packages across package manifests. It changes SidePanelToggleButton to use sidebarLeftIcon by default and simplifies transform and margin styling while preserving end-origin and RTL behavior.

Changes

SidePanel icon alignment

Layer / File(s) Summary
Package version alignment
package.json, modules/*/package.json
The manifests update @workday/canvas-system-icons-web to 4.2.0 and @workday/canvas-tokens-web to stable 4.4.0.
SidePanel toggle icon and styling
modules/react/side-panel/lib/SidePanelToggleButton.tsx
The default icon changes to sidebarLeftIcon. State styles retain margins, while origin-based styling handles mirroring and RTL behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: automerge

Suggested reviewers: mannycarrera4

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: updating SidePanel to use the sidebarLeft icon.
Linked Issues check ✅ Passed The changes update SidePanel to use sidebarLeftIcon, remove extendIcon-specific transforms, and preserve origin and RTL behavior.
Out of Scope Changes check ✅ Passed The dependency updates support the icon change, and the SidePanel code changes remain within the linked issue scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mannycarrera4
mannycarrera4 changed the base branch from master to support August 3, 2026 20:44
@alanbsmith
alanbsmith enabled auto-merge (squash) August 4, 2026 14:52
@mannycarrera4 mannycarrera4 added ready for review Code is ready for review and removed automerge ready for review Code is ready for review labels Aug 4, 2026
@mannycarrera4
mannycarrera4 disabled auto-merge August 4, 2026 14:54
@cypress

cypress Bot commented Aug 5, 2026

Copy link
Copy Markdown

Workday/canvas-kit    Run #11461

Run Properties:  status check passed Passed #11461  •  git commit 4b8f5b7587 ℹ️: Merge a0926b7f2ec8ae8214ce30b6fa20ba0cd1dc0a52 into 23b7a01723b0057b59410a2c3b3b...
Project Workday/canvas-kit
Branch Review ISSUE-4069
Run status status check passed Passed #11461
Run duration 02m 24s
Commit git commit 4b8f5b7587 ℹ️: Merge a0926b7f2ec8ae8214ce30b6fa20ba0cd1dc0a52 into 23b7a01723b0057b59410a2c3b3b...
Committer Alan B Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 809
View all changes introduced in this branch ↗︎
UI Coverage  19.56%
  Untested elements 1536  
  Tested elements 371  
Accessibility  99.44%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 68  

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the React SidePanel toggle button to use the newer sidebarLeftIcon (aligning the component with the v15 Figma spec) and bumps Canvas system icon + token dependencies to newer versions used across the repo.

Changes:

  • Updated SidePanel.ToggleButton default icon from extendIcon to sidebarLeftIcon and simplified the transform logic.
  • Bumped @workday/canvas-system-icons-web to 4.2.0 across packages.
  • Promoted @workday/canvas-tokens-web from 4.4.0-beta.0 to stable 4.4.0 across packages.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Locks updated dependency versions (icons/tokens) and related deduping.
package.json Bumps root dependencies for system icons and tokens.
modules/styling/package.json Aligns styling package dependencies to updated icons/tokens versions.
modules/styling-transform/package.json Aligns styling-transform dependencies to stable tokens.
modules/react/side-panel/lib/SidePanelToggleButton.tsx Switches default icon to sidebarLeftIcon and updates transform logic for origin handling.
modules/react/package.json Aligns React package dependencies to updated icons/tokens versions.
modules/preview-react/package.json Aligns preview-react dependencies to updated icons/tokens versions.
modules/labs-react/package.json Aligns labs-react dependencies to updated icons/tokens versions.
modules/docs/package.json Aligns docs package dependencies to updated icons/tokens versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
},
origin: {
start: {},
@alanbsmith
alanbsmith merged commit a96fd89 into Workday:support Aug 5, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Main SidePanel icon doesn't match Figma

4 participants