fix(spin-java-module): detect cyclic module requires when resolving Java compiler dependencies - #172
Merged
Conversation
…ava compiler dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractCompile,AbstractJavaDependencyAnalysis, andCustomizationPlugineach had a long-standingTODOnoting that a required module could turn out to require the module doing the requiring, forming a cycle that went undetected.This adds a
ModuleCycles.checkNotCyclichelper that throwsIllegalStateExceptionwhen a candidateJDKModuleDescriptorrequires the module currently resolving its dependencies, and wires it into all three sites: the workspace-project match inJavaCompilerPlugin.resolveRequiredCompilerPlugin, and the tworequires-clause matches (workspace project and external artifact) inCustomizationPlugin.getDependencies.While making this change, the duplicated logic for locating a project's
JavaCompilerPluginby required module name (previously copy-pasted betweenAbstractCompileandAbstractJavaDependencyAnalysis) was consolidated into the new staticJavaCompilerPlugin.resolveRequiredCompilerPluginmethod, so the cycle check only needed to be added once for that lookup path.