fix(spin-junit-module): find a project's own Maven/Gradle-built main output during test resolution - #173
Merged
Merged
Conversation
…output during test resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractDetectTestResolution.additionalSiblingCandidates()used to hardcode the.build/main/<target>path when looking for a project's own compiled main output, which only exists if spin itself built that output. A project compiled solely viamvn compileor Gradle -- never by spin -- has no.builddirectory at all, so its main classes silently dropped out of the test-resolution candidate list, surfacing as "cannot find symbol" for any type test sources referenced from main, even within the same package.The fix reuses
AbstractDetectResolution.resolveCompiledOutput, the same spin/Maven/Gradle-aware, freshest-by-mtime lookup already used for sibling-project candidates, instead of hand-rolling the spin-only path. That method's visibility was widened from package-private toprotectedsoAbstractDetectTestResolution, which lives in a different package but already extendsAbstractDetectResolution, can call it directly.A new
maven-built-mainfixture workspace and test (shouldIncludeMavenBuiltMainOutputInTestResolution) model a project with atarget/classesdirectory on disk but no.builddirectory, and run only thedetect.test.compilation.resolutiontask pattern so the project's own main compiler task never executes, deterministically simulating "already built by Maven, never built by spin."