fix: render favicons from self-contained PNG and ICO assets - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declared SVG favicon references an external PNG. Browsers omit that dependency when the SVG is used as an image, leaving a white tile even though the request succeeds. Use the existing self-contained PNG/ICO in Writer and Publisher metadata, and remove the unused SVG files and dedicated SVG routing entry.
Refs WriteHumanly/humanly-cloud#2401. Product artwork and page layout are unchanged. Five files, 13 removed lines; no dependencies or backend changes.
Validation:
git diff --checkpassed.This source PR does not promote current Community main to the frozen managed deployment. The prepared managed image applies only these favicon changes to the retained live source; existing Pricing removal and research links remain. Provider-specific release details are retained in the private Cloud issue.
The reported Google search result is separate: Chrome decoded an inline 28×28 PNG whose pixels already depict a broken-image symbol. The original Google crawl/transform is unknown. This patch fixes the independently reproduced SVG defect and does not promise an immediate search-result refresh. No search-platform account changes were made.
Production release (2026-09-24)
Owner approved merging and deploying after acceptance and review. PR #8 merged as
526ba5e21e7a6cfec27eb30b34a708b0893e58be; the ready-for-review CI rerun 36018448728 also passed, along with CodeQL and Dependency Review.The approved favicon patch is deployed to writehumanly.net using the existing managed production source. Production browser checks passed for homepage, login, research and article pages on desktop and mobile. PNG/ICO visibly decode with no SVG metadata; the mobile menu opens after hydration; there are no Pricing links and
/pricingreturns 404; both direct arXiv PDF links remain. No observed page JavaScript errors or horizontal overflow at 390px. Only the intended frontend container changed; the other six retain their prior IDs and images and all configured health checks are healthy.The exact reported Google query still serves the pre-existing inline bitmap depicting a broken-image symbol. The website release is verified; Google search-result refresh is separate and has not yet been observed.